Filter out decrypted attributes in ActiveRecord #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenjackson
force-pushed
the
filter_decrypted_attributes
branch
from
5a54b2f
to
1514027
Compare
e19445a introduced marking attr_encrypted attributes as virtual attributes to avoid an ActiveRecord deprecation warning in AR 5.1. This had the side effect of exposing the decrypted versions of the attributes in `ActiveRecord::Base#attributes`. This is problematic since the method is leveraged for things like `#as_json` and `respond_with`, meaning a user could inadvertely expose sensitive info with an action like: ``` def show respond_with @user end ```
stevenjackson
force-pushed
the
filter_decrypted_attributes
branch
from
c3d68bd
to
e1ec453
Compare
Slike9
reviewed
Jan 15, 2020
| def attributes | ||
| encrypted_keys = self.class.encrypted_attributes.keys | ||
| attributes_without_attr_encrypted.reject { |k, _| encrypted_keys.include?(k.to_sym) } | ||
| end |
There was a problem hiding this comment.
I guess there is an inconsistency. #has_attribute? will return true for encrypted attributes as it relies on @attributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e19445a introduced marking
attr_encryptedattributes as virtual attributes to avoid an ActiveRecorddeprecation warning in AR 5.1. This had the side effect of exposing
the decrypted versions of the attributes in
ActiveRecord::Base#attributes. This is problematic since the methodis leveraged for things like
#as_jsonandrespond_with, meaning auser could inadvertely expose sensitive info with an action like:
Closes #353