Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SAM C2x devices #662

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Support SAM C2x devices #662

wants to merge 3 commits into from

Conversation

jboynes
Copy link
Contributor

@jboynes jboynes commented Jan 7, 2023

Summary

Adds support for SAM C20 and C21 devices.

Added the SVD files downloaded from Atmel's site and generated the pac crates using svd2rust. Only modification made to SVD was the removal of some incorrect <enumeratedValue> for fields in GCLK:SYNCBUSY (see atsamc2x.xsl).

Although this is a big commit (sorry) all of the code in pac was generated. Please let me know if there's a better way to submit this.

This is a checkpoint before adding atsamc features to the hal.

Checklist

  • CHANGELOG.md for the BSP or HAL updated
  • All new or modified code is well documented, especially public items
  • No new warnings or clippy suggestions have been introduced (see CI or check locally)

If Adding a new Board

  • Board CI added to crates.json
  • Board is properly following "Tier 2" conventions, unless otherwise decided to be "Tier 1"

If Adding a new cargo feature to the HAL

  • Feature is added to the test matrix for applicable boards / PACs in crates.json

@bradleyharden
Copy link
Contributor

@jboynes, adding the PACs is the right way to start. But let's hold off until we get buy in from some of the other maintainers on #659.

@jboynes jboynes marked this pull request as draft January 7, 2023 19:31
@jboynes
Copy link
Contributor Author

jboynes commented Jan 7, 2023

No worries. I converted this to a draft for now. If it helps, I can split it into two PRs, one with new code and one containing only generated code.

I will create another branch to work on adding a BSP for the atsamc21_xpro that I can use for verification. I think that will help drive the changes needed in hal to support it.

@bradleyharden bradleyharden mentioned this pull request Jan 9, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants