Merged
Conversation
UncleGrumpy
requested changes
Nov 1, 2025
Collaborator
UncleGrumpy
left a comment
UncleGrumpy
left a comment
There was a problem hiding this comment.
I am still reviewing some of the more complex sections, but I have a few simple fixes and requests that I noticed in a first pass. It would also be good to have some tests to verify the assembled escript.
pguyot
force-pushed
the
w44/escriptize
branch
from
50deba6 to
da31bd3
Compare
Collaborator
|
We probably want a test too, before this is merged. I wasn’t completely on top of this before (see #57, a review there would be appreciated too ;-), but moving forward I would like to make sure all new features have tests. |
UncleGrumpy
reviewed
Dec 2, 2025
UncleGrumpy
reviewed
Dec 2, 2025
pguyot
force-pushed
the
w44/escriptize
branch
2 times, most recently
from
f50be09 to
ff5c0e2
Compare
Requires support for AtomVM: atomvm/AtomVM#1948 NB: it's currently incompatible with JIT Signed-off-by: Paul Guyot <pguyot@kallisys.net>
This makes a few small adjustments to the escriptize provider as well as the tests, most of these are necessary changes. A few additional changes have heen made, such as adding the users $HOME/.local, to the default AtomVV install search paths, and supporting matching on the AtomVM elf executable, as well as the shell launcher script. Signed-off-by: Winford <winford@object.stream>
pguyot
force-pushed
the
w44/escriptize
branch
from
468ee62 to
6fc8beb
Compare
UncleGrumpy
approved these changes
Dec 9, 2025
pguyot
force-pushed
the
w44/escriptize
branch
5 times, most recently
from
cea55dc to
4700716
Compare
Signed-off-by: Paul Guyot <pguyot@kallisys.net>
pguyot
force-pushed
the
w44/escriptize
branch
from
4700716 to
15b3e59
Compare
This will prevent objcopy from dammaging the binary on linux/arm64 Signed-off-by: Paul Guyot <pguyot@kallisys.net>
pguyot
force-pushed
the
w44/escriptize
branch
from
272f591 to
95225c9
Compare
Collaborator
|
If this is ready now I would love to merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires support for AtomVM:
atomvm/AtomVM#1948
NB: it's currently incompatible with JIT