Draft
Conversation
Store the class instance in CanvasDrawer property
aminya
changed the title
aminya
force-pushed
the
canvas-drawer
branch
5 times, most recently
from
6e3b9d2 to
eb7a8c6
Compare
Collaborator
Author
|
This is mostly working. One of the tests is failing which I need to debug. |
UziTech
approved these changes
Apr 5, 2021
Collaborator
UziTech
left a comment
UziTech
left a comment
There was a problem hiding this comment.
LGTM whenever the tests are passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make
CanvasDrawerclass independent, and store the class instance inCanvasDrawerpropertyBenefits
This decoupling allows doing further optimizations with the code. For example, not calling the state functions every time, and make them once during the constructor. It also allows removing all the mixin hackery and
mixto.It makes the who classes independent, so we know which properties are actually for
CanvasDrawer.