Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create codeql-analysis.yml #62

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rjatkins
Copy link

No description provided.

@rjatkins rjatkins requested a review from a team as a code owner January 14, 2022 05:59
@pczuj
Copy link
Contributor

pczuj commented Jan 14, 2022

Hi @rjatkins, would you be able to provide in the commit message a description of why are we intoducing this automation for this repository? When doing so you could also squash the 3 commits into 1 to keep the git history clean.

@dagguh
Copy link
Contributor

dagguh commented Jan 14, 2022

@pczuj you can also squash-merge it via GitHub GUI

@pczuj
Copy link
Contributor

pczuj commented Jan 14, 2022

@dagguh thanks for noting that.

I know about it, but then you have limited control over what exactly the content of the commit message will be. Also if we'd be fine to add description with reasoning then it has to be done on a specific commit. It's easier to pick if you have only one :D

@rjatkins
Copy link
Author

I was just trying to enable GitHub's own CodeQL security scanner for this repo, but that requires figuring out how to get GitHub Actions to be able to build the repo first. I see other JPT repos have switched to GitHub Actions from circleci, so maybe it'll be fixable by cribbing some of their configuration to this CodeQL action too.

@pczuj
Copy link
Contributor

pczuj commented Jan 18, 2022

@rjatkins I unfortunately don't know much about Github Actions. @mzyromski-atlassian was doing the transition for other repositories, so he should be able to help, however he is on sick leave right now based on his Slack status.

Ultimately I'd like to also learn about Github Actions, however right now I unfortunately don't have time for that.

@dagguh
Copy link
Contributor

dagguh commented Jan 18, 2022

They're straightforward, like Bitbucket Pipelines. I'd estimate porting to GHA would take 10-15 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants