Fix ktlint configuration and remove baselines because we don't need them anymore #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlam-atlassian
requested review from
douglasmarques,
tchernykh and
encryptededdy
tchernykh
reviewed
Nov 1, 2024
.editorconfig
Outdated
| @@ -19,22 +19,19 @@ trim_trailing_whitespace = true | |||
| insert_final_newline = true | |||
|
|
|||
| # To override IDEA default 120 columns | |||
There was a problem hiding this comment.
Doesn't matter much but comment does not seems to have any sense after the change. Is 120 default value? Could we remove that at all?
There was a problem hiding this comment.
Looks like 120 is default value for AndroidStudio, but default is 100 for ktlint.
I'll remove the comment since it doesn't make sense anymore.
tchernykh
reviewed
Nov 1, 2024
model/build.gradle.kts
Outdated
| @@ -7,6 +7,10 @@ plugins { | |||
| id("kotlinx-serialization") | |||
| } | |||
|
|
|||
| ktlint { | |||
| android.set(true) | |||
There was a problem hiding this comment.
What does it do? What is so special about android for the multiplatform project?
There was a problem hiding this comment.
oh this shouldn't be there. I was testing some stuff, but I don't think we need it. I'll remove it.
tchernykh
previously approved these changes
Nov 1, 2024
nlam-atlassian
dismissed stale reviews from tchernykh and doug-atlassian
via
32506f1
tchernykh
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.editorConfigwithktlint_code_style = android_studio. This fixed most of the lint issues../gradlew ktlintFormat