Start to vendor lmdb-js-lite #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamadapc
commented
Aug 20, 2024
| @@ -0,0 +1,453 @@ | |||
| //! This crate implements a LMDB wrapper for Node.js using N-API. | |||
There was a problem hiding this comment.
Source code is here
| @@ -0,0 +1,527 @@ | |||
| use std::path::Path; | |||
| { | ||
| current_size = current_size * 2; | ||
| tracing::info!("Resizing database {current_size}"); | ||
| unsafe { read.environment().resize(current_size).unwrap() } |
There was a problem hiding this comment.
I did not implement resizing because resizing requires us to put a lock around all the transactions so that we only resize when there are no open transactions. Even in that case it's hard to validate & it'll be a bit of UB to resize.
yamadapc
changed the title
mattcompiles
approved these changes
Aug 27, 2024
Nikola-3
pushed a commit
that referenced
this pull request
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts to add a Rust based wrapper for LMDB, as published in the
lmdb-js-litenpm package. That package will be deprecated and vendored into the parcel repository.This pull-request will be changed to that the LMDB bindings are built into the main bundler rust native add-on, rather than a separate one.