Add MCP (Model Context Protocol) integration to Application SDK #698
+1,789
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📜 Docstring Coverage ReportRESULT: PASSED (minimum: 30.0%, actual: 75.8%) Detailed Coverage Report |
📦 Trivy Vulnerability Scan Results
Report Summary
Scan Result Details✅ No vulnerabilities found during the scan for |
📦 Trivy Secret Scan Results
Report Summary
Scan Result Details✅ No secrets found during the scan for |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
|
🛠 Full Test Coverage Report: https://k.atlan.dev/coverage/application-sdk/pr/698 |
junaidrahim
requested changes
Sep 9, 2025
|
@AdvitXAtlan Let's refactor it in the following direction
|
junaidrahim
requested changes
Sep 11, 2025
junaidrahim
requested changes
Sep 11, 2025
Core Features: - Added @mcp_tool decorator for marking activities as MCP tools - Added MCPServer class that auto-discovers decorated activities - Enhanced BaseApplication with enable_mcp parameter and MCP methods - Added mcp optional dependency group Architecture: - Activities marked with @mcp_tool are automatically exposed - MCPServer reuses existing activity discovery logic from workflows - Clean integration: apps just add decorators + enable_mcp=True - No manual MCP server code needed in individual apps
- Add @mcp_tool decorator for marking activities as MCP tools - Implement MCPServer class with automatic tool discovery - Mount FastMCP server on FastAPI at /mcp endpoint - Support streamable HTTP transport for AI agent integration - Enable MCP through BaseApplication enable_mcp flag - Add FastMCP 2.0 as optional dependency - Support Claude Desktop integration via npx mcp-remote
- Add Pydantic BaseModel automatic parameter expansion for AI-friendly tools - Implement comprehensive unit test suite for MCP integration (37 tests) - Fix @mcp_tool decorator to support both @mcp_tool and @mcp_tool() syntax - Restructure test folders to mirror source code structure per standards - Add FastMCP integration test when library is available - Fix parameter ordering in Pydantic expansion (required before optional) - Improve type comparisons and remove unused imports per linting
AdvitXAtlan
force-pushed
the
feature/mcp-sdk-integration
branch
from
8fc9917 to
6f5534c
Compare
junaidrahim
reviewed
Sep 15, 2025
| # ... activity implementation unchanged ... | ||
| """ | ||
|
|
||
| def decorator(f): |
There was a problem hiding this comment.
please add a functools.wraps here
junaidrahim
requested changes
Sep 15, 2025
Comment on lines
+35
to
+41
| @mcp_tool | ||
| async def simple_activity(self, param: str) -> str: | ||
| pass | ||
|
|
||
| @mcp_tool(description="Fetch random GIF from Giphy API") | ||
| async def fetch_gif(self, search_term: str) -> str: | ||
| # ... activity implementation unchanged ... |
There was a problem hiding this comment.
please add the >>> prefix to the lines in this section of the docstring indicating the python REPL.
You can find an example here
This should fix the failing docs action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model Context Protocol (MCP) Integration for Application SDK
Summary
This PR adds comprehensive Model Context Protocol (MCP) support to the Atlan Application SDK.
Core Features:
Architecture:
Migration Guide
For existing applications wanting to add MCP support:
Install MCP dependencies:
pip install "atlan-application-sdk[mcp]"Decorate activities:
Enable MCP in application:
Changelog
fastmcp>=2.0.0in[mcp]extra@mcp_tooldecorator inapplication_sdk.decorators.mcp_toolMCPServerclass inapplication_sdk.servers.mcp.serverBaseApplicationwithenable_mcpparameter/mcpendpointAdditional context (e.g. screenshots, logs, links)
Checklist
Copyleft License Compliance