Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue #759 Let element exist in DOM before grabbing attribute (fix logo icon load issue) #902

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Issue #759 Let element exist in DOM before grabbing attribute (fix logo icon load issue) #902

wants to merge 1 commit into from

Commits on Sep 17, 2024

  1. Let element exist in DOM before grabbing attribute 

    Otherwise original code will initiate fallback process prematurely by attempting to grab the same icon in other logo types (which doesn't really make sense for logos anyway, but this should at least stop the prevailing issue).
    @kerryj89
    kerryj89 authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    aff3329 View commit details
    Browse the repository at this point in the history