-
-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(blog): the reference rabbit hole #461
chore(blog): the reference rabbit hole #461
Conversation
✔️ Deploy Preview for asyncapi-website ready! 🔨 Explore the source changes: 8afcb41 🔍 Inspect the deploy log: https://app.netlify.com/sites/asyncapi-website/deploys/61a5fb86af780b0007550239 😎 Browse the preview: https://deploy-preview-461--asyncapi-website.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nitpicks, some more useful than others to me, especially for readability.
Looks cool otherwise ! 👍
Co-authored-by: Sergio Moya <[email protected]>
Co-authored-by: Sergio Moya <[email protected]>
Removing request for review for a second, need to rewrite parts of it. |
Okay, I think it is good shape now 😅 Sorry for making you double review it @smoya 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @jonaslagoni !! I thought I had finished the review, now I see I left the comments pending! smh 🤦♀️
Ok, doing it right now :)
@derberg I have left my review successfully this time 😀 |
Co-authored-by: Alejandra Quetzalli <[email protected]>
Quality review as always @alequetzalli @smoya, addressed all your comments 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! 🚀 🌔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT 🚀 🌟
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review of @smoya and @alequetzalli were dismissed but only because I pushed publish date update, so I approve and we can merge. We release this article today
@jonaslagoni before we merge, are you 100% sure about the article title? me myself and I bet others too, decide to click on a link and read an article when I more or less know what it is about. Tbh |
Not sure, hate figuring out titles, this one just seemed natural. Especially since it is not really only about JSON Schema reference, but both 🤔 Sooo, not sure 😅 |
@jonaslagoni leaving it up to you, just tell me if I should release or not. Just sharing it on reddit or hackernews with this title will not increase much reach IMHO, which is fine if the article is purely for AsyncAPI community only |
What about something more descriptive then, something in the style of "JSON Schema $ref is not JSON Reference" (shouldnt be this one, it is just an example of the style) |
yo, I now read the article. Sorry, but tbh it is super specific to AsyncAPI, very technical and requires deep AsyncAPI understanding, so the title can be as it is as I don't see a point of putting it on reddit or hackernews but only on official AsyncAPI social accounts and their followers. Just please fix the broken link and I think we can go: |
@derberg done. |
Description
This blog post explains why and how the following issues came to be:
$ref
means two different things, depending on when it's used.$schema
and Message ObjectschemaFormat
$ref
and are not being ignored.$id
in the Schema Object when it should.