-
-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: missing equal sign in doc #3479
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThe pull request involves updates to the Changes
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3479 +/- ##
=======================================
Coverage 86.59% 86.59%
=======================================
Files 21 21
Lines 664 664
=======================================
Hits 575 575
Misses 89 89 ☔ View full report in Codecov by Sentry. |
@TenzDelek can you please add the issue here also |
@TenzDelek netlify preview is not available |
hmm, didnt quite get you there. doesn't it deploy automatically when we raise a pr back then? or do we have a command now for that cc @sambhavgupta0705 |
the netlify is pointing out to some issue with ruby cc @sambhavgupta0705 any thought on this? kinda strange cause only the md value was changed |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3479--asyncapi-website.netlify.app/ |
@sambhavgupta0705 fixed, probably due to network issue it seems cause redeploying it does the job |
i dont think there is any issue created for this as per the pr made by the last contributor |
@BhaswatiRoy @TRohit20 can you please review this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for identifying and fixing the typo in the command! @TenzDelek
LGTM! @sambhavgupta0705
it was identify by the previous contributor (#2904) , so all credit goes to her. |
Description
continue of #2904
Summary by CodeRabbit