fix: rendering issue with few components using next-i18n on community pages #3384
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| import React, { useState } from 'react'; | ||
|
|
||
| import EventFilter from '@/components/navigation/EventFilter'; | ||
| import EventPostItem from '@/components/navigation/EventPostItem'; | ||
| import Heading from '@/components/typography/Heading'; | ||
| import Paragraph from '@/components/typography/Paragraph'; | ||
| import meetings from '@/config/meetings.json'; | ||
| import type { Event } from '@/types/pages/community/Community'; | ||
| import { HeadingLevel, HeadingTypeStyle } from '@/types/typography/Heading'; | ||
| import { ParagraphTypeStyle } from '@/types/typography/Paragraph'; | ||
| import { getEvents } from '@/utils/staticHelpers'; | ||
|
|
||
| const CommunityEvents = () => { | ||
| const [events, setEvents] = useState(getEvents(meetings)); | ||
|
|
||
| return ( | ||
| <div className='mt-20'> | ||
| <div className='items-center justify-between sm:flex'> | ||
| <Heading level={HeadingLevel.h2} typeStyle={HeadingTypeStyle.md}> | ||
| All Events | ||
| </Heading> | ||
| <div className='mt-5 sm:mt-0'> | ||
| <EventFilter data={meetings} setData={setEvents} /> | ||
| </div> | ||
| </div> | ||
| <div className='mt-10'> | ||
| {!events || events.length === 0 ? ( | ||
| <div className='flex content-center justify-center'> | ||
| <Paragraph typeStyle={ParagraphTypeStyle.md} className='mx-auto mt-5 max-w-2xl'> | ||
| No Events. Check back later! | ||
| </Paragraph> | ||
| </div> | ||
| ) : ( | ||
| <ul className='grid grid-cols-1 gap-5 md:grid-cols-2 lg:grid-cols-3'> | ||
| {events.map((event: Event, index: number) => { | ||
| return <EventPostItem key={index} id={event.title} post={event} />; | ||
| })} | ||
|
Comment on lines
+35
to
+37
There was a problem hiding this comment. Avoid using array indices as React keys. Using array indices as keys can lead to issues with component state and performance when the list items can change (reordering, filtering, etc.). Consider using a unique identifier from the event data. -{events.map((event: Event, index: number) => {
- return <EventPostItem key={index} id={event.title} post={event} />;
+{events.map((event: Event) => {
+ return <EventPostItem key={event.title} id={event.title} post={event} />;
|
||
| </ul> | ||
| )} | ||
| </div> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default CommunityEvents; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Optimize state initialization to prevent unnecessary calculations.
The
getEvents(meetings)call in useState will run on every render. Consider optimizing this by either:Or with useMemo:
const CommunityEvents = () => { - const [events, setEvents] = useState(getEvents(meetings)); + const initialEvents = useMemo(() => getEvents(meetings), []); + const [events, setEvents] = useState(initialEvents);