Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improving the lighthouse Score#3356 #3367

Closed
wants to merge 1 commit into from
Closed

fix: Improving the lighthouse Score#3356 #3367

wants to merge 1 commit into from

Conversation

lakshaydewan
Copy link

@lakshaydewan lakshaydewan commented Nov 6, 2024 •
edited by coderabbitai bot
Loading

Improved the lighthouse score on mobile devices by preloading fonts and using Native Script tag from next/script
Screenshot 2024-11-06 at 10 47 30 PM

the FCP of the website went down from 3 seconds average to 1.5 seconds improving the performance greatly.

Summary by CodeRabbit

  • New Features

    • Enhanced script loading behavior with the introduction of the <Script> component for improved performance.
    • Added preloading for the Fira Code font stylesheet to optimize font loading.

  • Bug Fixes

    • Corrected the link tag for preconnecting to Google Fonts to ensure proper functionality.

  • Chores

    • Removed the Fira Code font import from global styles, streamlining font management.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Nov 6, 2024 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request involve modifications to the Next.js application, specifically in the way scripts and styles are managed. The <script> tags for loading external JavaScript have been replaced with the <Script> component from next/script, utilizing the strategy='lazyOnload' attribute for deferred loading. Additionally, corrections were made to the <Head> section in the _document.tsx file, including a fix for the Google Fonts link and the addition of a new link for preloading the Fira Code font. An import for the Fira Code font was removed from the global CSS file.

Changes

File Change Summary
pages/_app.tsx Replaced <script> tag with <Script> component from next/script with strategy='lazyOnload'.
pages/_document.tsx Added import for Script, corrected rel attribute for Google Fonts link, added preload link for Fira Code, replaced GitHub buttons script with <Script>.
styles/globals.css Removed import for Fira Code font while keeping other CSS imports intact.

Possibly related issues

Possibly related PRs

Suggested labels

ready-to-merge, bounty

Suggested reviewers

  • derberg
  • magicmatatjahu
  • Mayaleeeee
  • anshgoyalevil
  • sambhavgupta0705
  • BhaswatiRoy
  • J0SAL
  • TRohit20

Poem

🐰 In the garden where scripts do play,
A lazy load brightens the day.
Fonts now preload with style so neat,
Performance blooms, a joyful feat!
With each change, our app takes flight,
Hopping high, oh what a sight! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify Netlify
Copy link

netlify bot commented Nov 6, 2024 •
edited
Loading

✅ Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1e2f9e4
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/672ba61c9b79060008d2515f
😎 Deploy Preview https://deploy-preview-3367--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Nov 6, 2024 •
edited
Loading

We require all PRs to follow Conventional Commits specification.
More details 👇🏼

 The subject "Improving the lighthouse Score#3356" found in the pull request title "fix: Improving the lighthouse Score#3356" should start with a lowercase character.

@asyncapi-bot
Copy link
Contributor

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 47
🟢 Accessibility 98
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 33

Lighthouse ran on https://deploy-preview-3367--asyncapi-website.netlify.app/

@lakshaydewan lakshaydewan deleted the #3356-Performance-lighthouse branch November 6, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg Awaiting requested review from derberg derberg is a code owner

@akshatnema akshatnema Awaiting requested review from akshatnema akshatnema is a code owner

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@anshgoyalevil anshgoyalevil Awaiting requested review from anshgoyalevil anshgoyalevil is a code owner

@Mayaleeeee Mayaleeeee Awaiting requested review from Mayaleeeee Mayaleeeee is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

@devilkiller-ag devilkiller-ag Awaiting requested review from devilkiller-ag

@sambhavgupta0705 sambhavgupta0705 Awaiting requested review from sambhavgupta0705

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lakshaydewan @asyncapi-bot