-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add new sponsors to landing page #3151
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3151--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have the sponsors' logo in SVG or WEBP format?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm taking what they have, and do not feel comfortable doing any edits, that could affect quality of the brand colors. Other logos are also not always svg. These are super small files
@derberg Your CSS changes have made increased the size of logos abruptly in the mobile view |
you're right, one change too much - fixed and checked locally |
HDI logo size is way too huge as compared to others, so probably we have to built a component that restricts the logo size with fixed dimension. @derberg Can you please create an issue for this to normalize the logos of sponsors in the website? |
Yes on mobile view its size is very big |
@akshatnema on it please approve this pr so we can merge the change, one of sponsors is pushing a bit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve this pr, and then we can reduce the size of the logos in a follow-up issue.
/rtm |
HDI -> https://opencollective.com/asyncapi/contributions/781938
Route4Me -> https://opencollective.com/asyncapi/contributions/781793
Postman -> https://opencollective.com/asyncapi/contributions/780992
I've also added some extra changes to silver sponsor component to make sure we get maximum of 4 logos per line (to see 4+3, and with 5 + 2 it looked weird. I also made sure it looks fine on mobile.
before change in CSS
after change in CSS