Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add extension for glee project #2287

Closed
wants to merge 10 commits into from

Conversation

afzal442
Copy link
Contributor

@afzal442 afzal442 commented Nov 3, 2023

Description

Since we are documenting our glee project, I have added the config details and to sync it up with asynapi website.
For #480

Copy link

netlify bot commented Nov 3, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 34e1aed
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/656e0cf0d5b89a0008afb08c
😎 Deploy Preview https://deploy-preview-2287--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@afzal442
Copy link
Contributor Author

afzal442 commented Nov 7, 2023

Sorry @derberg could you review it?

@afzal442
Copy link
Contributor Author

afzal442 commented Nov 9, 2023

@derberg Am I missing out on sth?

@afzal442
Copy link
Contributor Author

afzal442 commented Nov 16, 2023

sorry @KhudaDad414 I have asked @derberg to review it for our glee documentation pages. I am not sure if it is automated.

@KhudaDad414
Copy link
Member

@afzal442 let's wait for one of the code owners review.

@derberg
Copy link
Member

derberg commented Nov 16, 2023

sorry folks, super focused on v3 now

you can automate - and you should automate all:

the thing is that to implement automation, you first need to manually check that it is correct

so in this PR you already manually tested the config and _section, but you also need to manually add the markdown files that your automation will normally copy over - this way here in PR preview you will be able to manually see:

  • if edit config is correct
  • if your docs render
  • and if you have correct front matter and docs show up properly, with good navigation and titles, and links

you know what I mean? so yeah, turn this PR into draft, as its intention is to never be merged - it is just for testing - and update with markdown files

@afzal442 afzal442 marked this pull request as draft November 16, 2023 16:52
@afzal442
Copy link
Contributor Author

afzal442 commented Nov 16, 2023

you know what I mean?

yep I got that. I tested it out against config and _section. Now I will add .md files to see how docs render. Thanks for cutting through it. 😄

@afzal442 afzal442 changed the title chore: add extension for glee project test: add extension for glee project Dec 4, 2023
@afzal442
Copy link
Contributor Author

test and experiment is done!

@afzal442 afzal442 closed this Dec 18, 2023
@afzal442 afzal442 deleted the create-ext-for-glee branch December 18, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants