refactor: improve website performance #1368
Conversation
Shofiya2003
requested review from
fmvilas,
derberg,
mcturco,
akshatnema,
magicmatatjahu and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
|
||
| setConfig({ |
There was a problem hiding this comment.
@derberg we need to add the cloudinary cloudname here, without this the build will fail
There was a problem hiding this comment.
I just created an account, name is dimfh6eps
what about API key and secret? don't you need them?
There was a problem hiding this comment.
@derberg I researched. I did not find use of the API key and secret to configure cloudinary's image transformation service.
I think that the service is a part of the free plan and does not require API secret. In the free tier the size of a single image should be within 10 MB. referred this
Should we use the service? I don't think there would be any security issues as the service is free for all.
There was a problem hiding this comment.
cool, 10MB is more than enough
so after adding the account name do you see it working in the preview?
There was a problem hiding this comment.
@derberg
Yup I saw the preview and used lighthouse for analytics
The solution seems to be improving the analytics of the blog page for the web but not for mobile. Will look into it and get back to you within a day with a better solution.
Shofiya2003
changed the title
Shofiya2003
changed the title
…iya2003/website into improve_website_performance
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1368--asyncapi-website.netlify.app/ |
|
ping @Shofiya2003. Kindly do let know what all sort of environment variables are needed to run this PR in development mode. |
|
Hey |
|
@Shofiya2003 lighthouse errors are fixed. You can continue, and please do 🙏🏼 as this PR makes good changes and really improves performance 🙏🏼 |
|
Hi @Shofiya2003 are you still working on this :3 ? |
|
I really wanted to work on this issue, but am busy with intern commitments.
Please go ahead if you want to work on it.
…On Mon, 4 Sep, 2023, 10:47 pm Anish, ***@***.***> wrote:
Hi @Shofiya2003 <https://github.com/Shofiya2003> are you still working on
this :3 ?
—
Reply to this email directly, view it on GitHub
<#1368 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUXSDRR4FTFBX36AWTT72HDXYYELVANCNFSM6AAAAAAVH36B7A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@Shofiya2003 sorry to hear that, but thanks for starting the very promising work 🙇🏼 @AnishKacham please go ahead. Please go ahead with new PR |
Description
Related issue(s)
#89