refactor: limit dropdown height of tools filter #1323
Conversation
co-decode
requested review from
fmvilas,
derberg,
mcturco,
akshatnema,
magicmatatjahu and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1323--asyncapi-website.netlify.app/ |
|
@akshatnema please have a look 🙏🏼 |
There was a problem hiding this comment.
Hey @co-decode, sorry for the late review 🙏. Regarding the dropdown height, yeah we do need to limit the dropdown height but we can't remove the scroll from it. You need to implement a new Dropdown for the Filters so that it looks perfect in both desktop and mobile view. You can get the reference of the dropdowns from https://deploy-preview-1330--asyncapi-website.netlify.app/tools, where you can see the Jump to Category section and it's dropdown.
|
no response from @co-decode so closing, as there are conflicts anyway and it is old PR. @co-decode please feel free to open a new PR |
Description
Dropdown for the filter of the tools dashboard would extend too far down the page.
These are my initial ideas for dealing with this issue.
Please let me know if I can improve upon them, this is a cool project and I'd like to help out!
Related issue(s)
Resolves #1318