Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] layout of tree in specification explorer doesnt reorganize on collapsing #3334

Closed
2 tasks done
catosaurusrex2003 opened this issue Oct 27, 2024 · 10 comments
Closed
2 tasks done
Labels

Comments

@catosaurusrex2003
Copy link
Contributor

Describe the bug.

see the blank space between components and operations

whenever you expand and collapse a node in the tree the blank space is retained by the node even though it is not expanded.

image

Expected behavior

when i collapse a node A and then expand another node B

node A should not have extra blank space as its children are hidden

Screenshots

added

How to Reproduce

  1. go to https://www.asyncapi.com/docs/reference/specification/v3.0.0-explorer
  2. expand components
  3. collapse components
  4. expand channels
  5. see the blank space

🥦 Browser

Mozilla Firefox

👀 Have you checked for similar open issues?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

Yes I am willing to submit a PR!

Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@hkv24
Copy link
Contributor

hkv24 commented Oct 28, 2024

@catosaurusrex2003 could you please provide few files which might have the logic of rendering this tree

@catosaurusrex2003
Copy link
Contributor Author

@hkv24 I'm not quite sure what you mean by 'files.' Could you clarify that for me?

I was just exploring the asyncapi spec https://www.asyncapi.com/docs/reference/specification/v3.0.0-explorer when i encountered this

@hkv24
Copy link
Contributor

hkv24 commented Oct 28, 2024

@catosaurusrex2003 I meant the file from the codebase. Anyway did you figured out something to solve this one?

@catosaurusrex2003
Copy link
Contributor Author

I haven't started working on this issue yet and was hoping to see if others encounter it first to confirm it's a legitimate concern. But if you’d like to solve it, feel free to go ahead!

@visheshkrishna
Copy link

@catosaurusrex2003 I see that the issue still persists, can you mention the name of the file where the actually logic of this issue lies ?

@JeelRajodiya
Copy link
Contributor

JeelRajodiya commented Oct 31, 2024

Hello everyone, for those of you who were asking for the files which are responsible for the issue.

Here is the file, I don't know if the issue can be resolved by just editing that file since we are using schyma library to render the tree, so you should consider opening an issue and PR on that repository to resolve the issue.

@catosaurusrex2003
Copy link
Contributor Author

@JeelRajodiya thanks 👌
I was just about to comment on that too 😆

I will be opening a PR in https://github.com/AceTheCreator/schyma soon

@BiradarScripts
Copy link

hey is this issue still open,i wanted to give it a try?

@catosaurusrex2003
Copy link
Contributor Author

@BiradarScripts
The issue has already been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants