New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: layout problem on collapsing a node with many children #4

Closed

catosaurusrex2003 wants to merge 3 commits into AceTheCreator:main from catosaurusrex2003:layout-bug-on-collapsing-node

Contributor

catosaurusrex2003 commented Oct 31, 2024

Changes in the PR:

added a removeEdgesByParent function to remove the remnant edges of a node when we are collapsing it.
converted dependency dagre to @dagrejs/dagre bcz of this https://github.com/dagrejs/dagre/blob/master/README.md
moved instance of dagreGraph and getLayoutedElements one level up from Node.tsx -> App.tsx so that every time our App.tsx rerenders a new fresh layout is created.

related:
asyncapi/website#3334

catosaurusrex2003 added 3 commits

October 31, 2024 21:06


          done changes

a04c69c


          removed some useless formattings

4b131f7


          removed more useless formattings

bda2172

Contributor Author

catosaurusrex2003 commented Nov 2, 2024 •

edited

Loading

closing this PR.
cuz created a new PR pointing to next branch
#5

catosaurusrex2003 closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet