Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make v3 default #841

Merged
merged 5 commits into from
Nov 8, 2023
Merged

Conversation

Shurtu-gal
Copy link
Collaborator

@Shurtu-gal Shurtu-gal commented Nov 3, 2023

Description

  • Make v3 as the default
  • When loading V3 is default

Related issue(s)
Fixes #832

Copy link

changeset-bot bot commented Nov 3, 2023

⚠️ No Changeset found

Latest commit: 0b6313c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Nov 3, 2023

Deploy Preview for modest-rosalind-098b67 ready!

Name Link
🔨 Latest commit 0b6313c
🔍 Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/654b62fda2d3900008d5d196
😎 Deploy Preview https://deploy-preview-841--modest-rosalind-098b67.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 3, 2023

Deploy Preview for asyncapi-studio-design-system ready!

Name Link
🔨 Latest commit 0b6313c
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/654b62fd0ba6ba0009a32f9d
😎 Deploy Preview https://deploy-preview-841--asyncapi-studio-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Shurtu-gal
Copy link
Collaborator Author

@Amzani Should I update the default doc as well?

@Shurtu-gal Shurtu-gal marked this pull request as draft November 3, 2023 11:59
@Shurtu-gal Shurtu-gal marked this pull request as ready for review November 3, 2023 13:01
@Amzani
Copy link
Collaborator

Amzani commented Nov 3, 2023

/progress 80

Ready to review

Copy link
Member

@KhudaDad414 KhudaDad414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙇 lets wait for @Amzani review.

Copy link

sonarcloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Amzani
Copy link
Collaborator

Amzani commented Nov 8, 2023

LGTM, however let's merge it once we fix #842

@asyncapi-bot asyncapi-bot merged commit 3af6078 into asyncapi:master Nov 8, 2023
20 checks passed
@Shurtu-gal Shurtu-gal deleted the feat/v3-default branch September 15, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make v3 default
4 participants