ci: publish AsyncAPI Studio Docker image with additional version tag #1150
Conversation
fgreinacher
requested review from
magicmatatjahu,
KhudaDad414,
Amzani,
Shurtu-gal and
asyncapi-bot-eve
as code owners
🦋 Changeset detectedLatest commit: 0ed5289 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
❌ Deploy Preview for studio-next failed.
|
✅ Deploy Preview for modest-rosalind-098b67 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -17,10 +17,18 @@ jobs: | |||
| username: ${{ secrets.DOCKER_USERNAME }} | |||
| password: ${{ secrets.DOCKER_PASSWORD }} | |||
|
|
|||
| - name: Get current Studio version | |||
| id: get-studio-version | |||
| uses: martinbeentjes/[email protected] | |||
There was a problem hiding this comment.
| asyncapi/studio:latest | ||
| asyncapi/studio:${{ steps.get-studio-version.outputs.current-version}} |
There was a problem hiding this comment.
Syntax as mentioned in https://github.com/docker/build-push-action?tab=readme-ov-file#inputs
✅ Deploy Preview for asyncapi-studio-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/ptal |
|
@Amzani @magicmatatjahu @KhudaDad414 @Shurtu-gal Please take a look at this PR. Thanks! 👋 |
|
/ptal Let me know what I can do to make your review easier 🙇 |
|
@Amzani @magicmatatjahu @KhudaDad414 @Shurtu-gal Please take a look at this PR. Thanks! 👋 |
| @@ -17,10 +17,18 @@ jobs: | |||
| username: ${{ secrets.DOCKER_USERNAME }} | |||
| password: ${{ secrets.DOCKER_PASSWORD }} | |||
|
|
|||
| - name: Get current Studio version | |||
| id: get-studio-version | |||
| uses: martinbeentjes/[email protected] | |||
There was a problem hiding this comment.
Could you change the version to a commit SHA based version?
Something like docker/build-push-action@f2a1d5e99d037542a71f64918e516c093c6f3fc4
There was a problem hiding this comment.
@Shurtu-gal Sure, done!
|
|
/rtm |
Description
This PR extends the Docker publishing workflow so that an additonal version tag is published to Docker Hub. This already happened before the migration from
semantic-releasetochangesets. I think it's desirable to bring it back because there are only super outdated versions on Docker Hub right now: https://hub.docker.com/r/asyncapi/studio/tags.Related issue(s)
Let me know if I should create one.
⚒️ with ❤️ by Siemens