Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADR-0006] Use Next.js framework #1090

Merged
merged 1 commit into from
Apr 29, 2024
Merged

[ADR-0006] Use Next.js framework #1090

merged 1 commit into from
Apr 29, 2024

Conversation

KhudaDad414
Copy link
Member

Description

Following the discussion in #661 this PR makes it official to use Next.js

Related issue(s)

fixes #1063

Copy link

changeset-bot bot commented Apr 29, 2024

⚠️ No Changeset found

Latest commit: d1c538a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for asyncapi-studio-design-system ready!

Name Link
🔨 Latest commit d1c538a
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-studio-design-system/deploys/662f98adfaa16c00089bca0f
😎 Deploy Preview https://deploy-preview-1090--asyncapi-studio-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for modest-rosalind-098b67 ready!

Name Link
🔨 Latest commit d1c538a
🔍 Latest deploy log https://app.netlify.com/sites/modest-rosalind-098b67/deploys/662f98ad28591400091ed923
😎 Deploy Preview https://deploy-preview-1090--modest-rosalind-098b67.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for studio-next ready!

Name Link
🔨 Latest commit d1c538a
🔍 Latest deploy log https://app.netlify.com/sites/studio-next/deploys/662f98ad5d91f20008b4a6b6
😎 Deploy Preview https://deploy-preview-1090--studio-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Collaborator

@Amzani Amzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KhudaDad414 KhudaDad414 added the kind/adr create a new architectural decision record. label Apr 29, 2024
@KhudaDad414
Copy link
Member Author

/rtm

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Apr 29, 2024

Hey there and thank you for opening this ADR pull request! 👋🏼
The ADR Pull request must change only the ADR file that match doc/adr/0006-*.md
You have changed theses files:

doc/adr/0007-use-nextjs.md

@asyncapi-bot asyncapi-bot merged commit 15f369c into master Apr 29, 2024
32 of 35 checks passed
@asyncapi-bot asyncapi-bot deleted the KhudaDad414-patch-1 branch April 29, 2024 15:53
@KhudaDad414
Copy link
Member Author

@Amzani

I am not sure what I did wrong. The error message is not helping. 🤔

Hey there and thank you for opening this ADR pull request! 👋🏼 The ADR Pull request must change only the ADR file that match doc/adr/0006-*.md You have changed theses files:

doc/adr/0007-use-nextjs.md

@Amzani
Copy link
Collaborator

Amzani commented Apr 30, 2024

@KhudaDad414, Title of this PR is [ADR-0006]... but your file is doc/adr/0007-use-nextjs.md it should be doc/adr/0006-use-nextjs.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/adr create a new architectural decision record. ready-to-merge
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add an ADR for using Next.js
3 participants