Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add Sergio and Vladimir as code owners #846

Merged
merged 3 commits into from
Oct 10, 2022
Merged

chore: add Sergio and Vladimir as code owners #846

merged 3 commits into from
Oct 10, 2022

Conversation

fmvilas
Copy link
Member

@fmvilas fmvilas commented Oct 4, 2022 •
edited
Loading

Related issues

Closes #844
Closes #845

asyncapi/spec-json-schemas#271

@derberg
Copy link
Member

derberg commented Oct 4, 2022

@fmvilas please

  • update description in the way that related issues will be closed after merge
  • open the same PR in spec-json-schema repo
  • I'd like to suggest that with the merge we also agree on some official written-down review rules. For now, we had an unwritten rule that all codeowners had to approve PRs, but we did not have it defined in the settings of branch protection. Imho, we should stay with 3 minimum approvers + some time for others to have time to vote. Cause getting 5 approvers will be super hard for each PR without any deadlines.

@fmvilas
Copy link
Member Author

fmvilas commented Oct 4, 2022

@derberg done.

I'd like to suggest that with the merge we also agree on some official written-down review rules. For now, we had an unwritten rule that all codeowners had to approve PRs, but we did not have it defined in the settings of branch protection. Imho, we should stay with 3 minimum approvers + some time for others to have time to vote. Cause getting 5 approvers will be super hard for each PR without any deadlines.

Yeah, agree. I can change the branch protection now if you agree with the proposed rules.

smoya
smoya reviewed Oct 5, 2022
View reviewed changes
CONTRIBUTING.md Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

smoya
smoya approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@fmvilas
Copy link
Member Author

fmvilas commented Oct 7, 2022

Alright, can I get some ✅ here? 😄 @dalelane @derberg

derberg
derberg approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@char0n have a look so you are also aware of changes and agree

dalelane
dalelane approved these changes Oct 8, 2022
View reviewed changes
Copy link
Collaborator

@dalelane dalelane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

char0n
char0n approved these changes Oct 10, 2022
View reviewed changes
Copy link
Collaborator

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmvilas
Copy link
Member Author

fmvilas commented Oct 10, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit 949a9ff into asyncapi:master Oct 10, 2022
@derberg
Copy link
Member

derberg commented Oct 10, 2022

@char0n As a maintainer in one of AsyncAPI projects (spec and spec-json-schema) you also have the right to join the AsyncAPI TSC and participate in the decision-making process for the entire AsyncAPI Initiative. Just lemme know if you are interested to learn more.

@fmvilas fmvilas deleted the add-sergio-and-char0on-to-codeowners branch October 10, 2022 15:24
@fmvilas fmvilas mentioned this pull request Oct 10, 2022
Merged
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next-major-spec.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@char0n
Copy link
Collaborator

char0n commented Oct 11, 2022

@derberg sure I'm always interested to learn more ;]

@derberg
Copy link
Member

derberg commented Oct 11, 2022

@char0n awesome, please open a PR like Jerremy did recently asyncapi/community#473 and mention all the 3 repos where you are now a codeowner please

@smoya smoya mentioned this pull request Oct 20, 2022
Merged
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg derberg approved these changes

@dalelane dalelane dalelane approved these changes

@smoya smoya smoya approved these changes

@char0n char0n char0n approved these changes

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released on @next-major-spec released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vladimir joining as code owner Sergio joining as code owner
6 participants
@fmvilas @derberg @asyncapi-bot @char0n @smoya @dalelane