Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update next-spec branch with master changes #831

Merged
merged 25 commits into from
Sep 14, 2022
Merged

chore: update next-spec branch with master changes #831

merged 25 commits into from
Sep 14, 2022

Conversation

char0n
Copy link
Collaborator

@char0n char0n commented Sep 9, 2022 •
edited
Loading

This is PR is part of #830 and updates next-spec branch with changes from master.

smoya and others added 22 commits May 10, 2022 15:10
@smoya
docs(contributors): update Contributors section considering latest re…
ea42f64 
…leases (asyncapi#784)
@smoya
ci(release): use new branch naming strategy (asyncapi#785)
af0ac96
@asyncapi-bot
ci: update generic workflows (asyncapi#793)
444f28a
@jonaslagoni
docs: fix wrong message payload for social media (asyncapi#798)
5245e43
@asyncapi-bot
chore: update code of conduct (asyncapi#800)
f4914e8
@aborg0
docs: fix example for examples in the payload schema (asyncapi#701)
d1c90fa
@asyncapi-bot
ci: update generic workflows (asyncapi#802)
6c3ab0c
@smoya
docs(release): update list of tools and maintainers to notify when re…
84576c8 
…leasing (asyncapi#770)
@quetzalliwrites
ci: updating spec urls to match new Information Architecture in websi…
70d0d67 
…te (asyncapi#801)
@KhudaDad414
docs: fix links in Markdown files (asyncapi#769)
77e428f
@jonaslagoni
docs: adapting release process to new definition setup (asyncapi#659)
03a7a95
@mike-schenk
docs: fix URN examples (asyncapi#718)
8612838
@asyncapi-bot
ci: update generic workflows (asyncapi#812)
89990fa
@char0n
docs: end OAuth Flows Object field descriptions always with dot (asyn…
9196699 
…capi#815)
@derberg
docs: extend example for kafka with x509 security (asyncapi#670)
d252352
@smoya
ci: improve GH ISSUE_TEMPLATE.md (asyncapi#791)
8094383
@char0n
docs: improve license application (asyncapi#783)
b7dc55f
@char0n
docs: specify the source of truth for the spec (asyncapi#781)
02393d1
@asyncapi-bot
ci: update generic workflows (asyncapi#824)
884d94c
@char0n
docs: clarify the resolution rules of Channel Item $ref field (asyn…
9a293c7 
…capi#779)
@char0n
docs: clarify how URL form is resolved (asyncapi#782)
fc324ef
@char0n
docs: align wording with RFC 2119 (asyncapi#818)
5580a9c
@char0n
Copy link
Collaborator Author

char0n commented Sep 9, 2022 •
edited
Loading

https://xml2rfc.ietf.org/public/rfc/html/rfc3339.html URL is used twice within the spec and it seems like it's dead. Let's wait a bit to see if it's just a temporary 404 or permanent one.

Update:
Looks like a permanent change. I'm suggesting to replace https://xml2rfc.ietf.org/public/rfc/html/rfc3339.html#anchor14 with https://www.rfc-editor.org/rfc/rfc3339.html#section-5.6. I'll make a PR with the editorial change for master branch - #832.

@char0n char0n mentioned this pull request Sep 9, 2022
Closed
61 tasks
@char0n
Copy link
Collaborator Author

char0n commented Sep 9, 2022

Verification question - I've created this PR by merging master branch with next-spec and issuing a PR containing the merges + a merge commit. There are other ways to achieve the same. Is there any preference in how to achieve the goal of updating the next-spec branch from master? If yes please let me know.

@char0n char0n force-pushed the char0n/next-spec-update-from-master branch from e751d7e to 4ca3409 Compare September 9, 2022 18:00
char0n added a commit to char0n/spec that referenced this pull request Sep 9, 2022
@char0n
fix(spec): change invalid RFC3339 link for valid one
c5dc22d 
Refs asyncapi#831
@char0n char0n mentioned this pull request Sep 9, 2022
Merged
@char0n char0n force-pushed the char0n/next-spec-update-from-master branch from 2491030 to 46514d0 Compare September 13, 2022 09:13
@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@char0n
Copy link
Collaborator Author

char0n commented Sep 13, 2022

@derberg @fmvilas @dalelane this is ready for review. The links check reports incorrectly failure. The links have been fixed on master and the commit is part of my forked branch as well. So I assume that link checker is checking next-spec branch instead of running the check on the merge commit of my forked branch + next-spec branch.

@derberg
Copy link
Member

derberg commented Sep 13, 2022

I guess you need to update this one because of #832

@char0n
Copy link
Collaborator Author

char0n commented Sep 14, 2022

@derberg it was already updated yesterday
image

@char0n char0n mentioned this pull request Sep 14, 2022
Merged
@derberg
Copy link
Member

derberg commented Sep 14, 2022

oh, ok, I'll check why markdown link checker fails then

@derberg
Copy link
Member

derberg commented Sep 14, 2022

omg, again, failing because of a link that is actually removed.
let's merge it as it is going to next branch, and the links checker is still in "beta" and we do not have it as mandatory check

I hope https://github.com/asyncapi/spec/pull/827/files#r968898025 will solve it

derberg
derberg approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/rtm

@derberg
Copy link
Member

derberg commented Sep 14, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit 250e9c9 into asyncapi:next-spec Sep 14, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.5.0-next-spec.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.5.0-next-major-spec.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@fmvilas
Copy link
Member

fmvilas commented Sep 22, 2022

Forget about the last comment saying it was released in version 2.5.0-next-major-spec.1. I made a mistake and it created this version but it should actually be 3.0.0-next-major-spec.1. There's a notice in the release. Apologies for the noise.

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.5.0-next-spec.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@derberg
Copy link
Member

derberg commented Jan 31, 2023

Recent comments about the release from the bot were added by mistake. More details in #899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg derberg approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas fmvilas is a code owner

@dalelane dalelane Awaiting requested review from dalelane dalelane is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released on @next-major-spec released on @next-spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.