Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add linkedin extension support #528

Merged
merged 9 commits into from
Apr 25, 2024
Merged

feat: add linkedin extension support #528

merged 9 commits into from
Apr 25, 2024

Conversation

sambhavgupta0705
Copy link
Member

@sambhavgupta0705 sambhavgupta0705 commented Apr 20, 2024

this pr add essential schemas to add support for linkedin extension
asyncapi/extensions-catalog#78
cc: @derberg

derberg
derberg previously approved these changes Apr 22, 2024
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@derberg
Copy link
Member

derberg commented Apr 22, 2024

Anyone else wanna have a look?

With this PR @sambhavgupta0705 basically validates that https://github.com/asyncapi/spec-json-schemas?tab=readme-ov-file#extensions instruction works. Also simplistic contribution flow to asyncapi/extensions-catalog#144 works as well.

Once we merge this I think we can say we have super minor nice MVP of extension catalog:

Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple change requested here #528 (comment)

The rest LGTM 👍 🚀

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀🌔

@derberg
Copy link
Member

derberg commented Apr 25, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit 8bf62c4 into asyncapi:master Apr 25, 2024
10 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 6.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants