-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add the 2.3.0.json version, and add the Solace binding. #136
feat: add the 2.3.0.json version, and add the Solace binding. #136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MichaelDavisSolace sorry but unfortunately you will have to recreate this PR, like create new, unless you are a git expert and can handle it here.
Basically problem is that you cat your branch from master
and not release branch and you are now pushing lots of stuff not related to your PR. We should have only your solace
binding related things.
Also to better handle next contribs, we need to let #139 in tomorrow first and this will for sure cause some conflicts in your PR, sorry about that :(
No problem! |
Replaced by 143, which branches off the feature branch. |
Description
This adds a new version 2.3.0.json and adds the solace binding to the list of bindings.
Related issue(s)
The related PR on the spec itself is here: asyncapi/spec#666