Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the 2.3.0.json version, and add the Solace binding. #136

Closed

Conversation

damaru-inc
Copy link

Description
This adds a new version 2.3.0.json and adds the solace binding to the list of bindings.

Related issue(s)
The related PR on the spec itself is here: asyncapi/spec#666

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@damaru-inc damaru-inc changed the title feat: Add the 2.3.0.json version, and add the Solace binding. feat: add the 2.3.0.json version, and add the Solace binding. Dec 8, 2021
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichaelDavisSolace sorry but unfortunately you will have to recreate this PR, like create new, unless you are a git expert and can handle it here.

Basically problem is that you cat your branch from master and not release branch and you are now pushing lots of stuff not related to your PR. We should have only your solace binding related things.

Also to better handle next contribs, we need to let #139 in tomorrow first and this will for sure cause some conflicts in your PR, sorry about that :(

@damaru-inc
Copy link
Author

@MichaelDavisSolace sorry but unfortunately you will have to recreate this PR, like create new, unless you are a git expert and can handle it here.

Basically problem is that you cat your branch from master and not release branch and you are now pushing lots of stuff not related to your PR. We should have only your solace binding related things.

Also to better handle next contribs, we need to let #139 in tomorrow first and this will for sure cause some conflicts in your PR, sorry about that :(

No problem!

@damaru-inc
Copy link
Author

Replaced by 143, which branches off the feature branch.

@damaru-inc damaru-inc closed this Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants