-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: escape < >
symbols
#542
Conversation
…ment` from `@asyncapi/parser`
…hould render bindings for operation`
# Conflicts: # package-lock.json
/ptal |
@fmvilas @derberg @magicmatatjahu Please take a look at this PR. Thanks! 👋 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that was fast
I think escaping work with one slash, not 2, cause then you see of of the slashes in rendered markdown
| Name | Type | Description | Value | Constraints | Notes |
|---|---|---|---|---|---|
| (root) | array\\<string\\> | - | - | [ 1 .. 5 ] unique items | - |
why not choosing to simply add code block as the person that reported the issue wanted, so
| Name | Type | Description | Value | Constraints | Notes |
|---|---|---|---|---|---|
| (root) | `array<string>` | - | - | [ 1 .. 5 ] unique items | - |
that renders event better
or
| Name | Type | Description | Value | Constraints | Notes |
|---|---|---|---|---|---|
| (root) | array<string> | - | - | [ 1 .. 5 ] unique items | - |
that also works
I think codeblocks is not the best choice, because we will have different visual formatting for types and lose consistency. But P.S. It seems me IDE problem. I tryied to use one escape, but md looked wrong(like I change nothing). |
1 similar comment
I think codeblocks is not the best choice, because we will have different visual formatting for types and lose consistency. But P.S. It seems me IDE problem. I tryied to use one escape, but md looked wrong(like I change nothing). |
ok, then lets be on the safe side and use what works, which is |
@derberg Could you take a look again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect work, thanks a 💯 !
Quality Gate passedIssues Measures |
/rtm |
🎉 This PR is included in version 1.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
In order to allow different tools to correctly show
array
|tuple
types of properties in schema we need to escape special symbols -<
,>
.Related issue(s)
Fixes #365