Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error message on missing auth function #695

Merged

Conversation

srini047
Copy link
Contributor

Description

  • Updated the current error message for more clear error debug.

Related issue(s)

Fixes: #688

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

sonarcloud bot commented Jan 20, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Souvikns
Copy link
Member

The tests are not running for some reason @srini047 can you make a minor change and push it.

Copy link

sonarcloud bot commented Mar 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@srini047
Copy link
Contributor Author

The tests are not running for some reason @srini047 can you make a minor change and push it.

@Souvikns I have made minor changes. If still the issue persists, can you let me know. Still wondering why checks are not running.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8299077097

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.884%

Totals Coverage Status
Change from base Build 7569347976: 0.0%
Covered Lines: 388
Relevant Lines: 483

💛 - Coveralls

@srini047
Copy link
Contributor Author

@Souvikns
Can you take a look at it now. I think all the required and generic checks except PR approval checks are passing.

Copy link
Member

@Souvikns Souvikns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@Souvikns
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit e9165c4 into asyncapi:master Mar 17, 2024
11 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.35.22 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improved Error Messaging for Missing Auth Function
4 participants