fix: make some improvements #363
Conversation
KhudaDad414
requested review from
fmvilas,
jonaslagoni and
asyncapi-bot-eve
as code owners
Pull Request Test Coverage Report for Build 3574061757Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
src/adapters/ws/index.ts
Outdated
| this.emit('message', msg, ws) | ||
| }) | ||
|
|
||
| this.emit('server:connection:open', { name: this.name(), adapter: this, connection: ws, channel: pathname, request }) | ||
| }) | ||
|
|
||
| this.emit('connect', { name: this.name(), adapter: this, connection: ws, channel: pathname }) |
There was a problem hiding this comment.
We should get rid of this connect event. As per documentation, connect is only triggered when Glee is a client but in this case it behaves as a server.
Co-authored-by: Fran Méndez <[email protected]>
Co-authored-by: Fran Méndez <[email protected]>
Co-authored-by: Fran Méndez <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
LGTM 👍
Pinging @Souvikns @sudoshreyansh @Ruchip16 @atharvagadkari05 too in case they want to review.
|
/rtm |
|
🎉 This PR is included in version 0.11.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Pull Request Test Coverage Report for Build 3572416881Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Description
I was working on an example project to get myself familiarize with glee I think these changes will fix a few bugs and make some improvements.