test: adding tests for template websockets components #1351
Conversation
DhairyaMajmudar
requested review from
derberg,
magicmatatjahu,
jonaslagoni and
asyncapi-bot-eve
as code owners
|
DhairyaMajmudar
changed the title
DhairyaMajmudar
changed the title
There was a problem hiding this comment.
try writing tests without mocks included but reuse maybe https://github.com/asyncapi/generator/blob/master/packages/helpers/test/__fixtures__/asyncapi-websocket-query.yml like this: https://github.com/asyncapi/generator/blob/master/packages/components/test/components/models.test.js#L6
and then, if it works, that we "cross-use" fixtures between projects, maybe the file should be moved to a "generic" test fixtures folder
|
Updated the PR with suggested changes 👍🏻 |
|
| const info = { | ||
| title: () => parsedAsyncAPIDocument.info.title, | ||
| version: () => parsedAsyncAPIDocument.info.version, | ||
| }; | ||
|
|
||
| const serverWithPathname = { | ||
| protocol: () => parsedAsyncAPIDocument.servers()[3].protocol(), | ||
| host: () => parsedAsyncAPIDocument.servers()[3].host(), | ||
| pathname: () => parsedAsyncAPIDocument.servers()[3].pathname(), | ||
| hasPathname: () => true | ||
| }; |
There was a problem hiding this comment.
why do you still want to maintain this code if you already have parsedAsyncAPIDocument and can access data using parser?
you have this
const wrapperWithoutPathname = FileHeaderInfo({ info, server: serverWithoutPathname });
so why not refactor to this
const wrapperWithoutPathname = FileHeaderInfo({ parsedAsyncAPIDocument.info(), parsedAsyncAPIDocument.servers().get('withPathname') });
Description
Adding testing files for template websockets component:
RequiresandFileHeaderInfoRelated issue(s)
fixes: #1346, #1347, #1348
Tests are running file locally
Screenshots