fix: add missing params validation in testFile_md component #1309
Conversation
toffee-k21
requested review from
derberg,
magicmatatjahu,
jonaslagoni and
asyncapi-bot-eve
as code owners
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
Hey @toffee-k21 you have changed in wrong file. You have to do in 'apps/generator/test/test-templates/react-template/template/test-file.md.js' this file but you have done in autogenerated file 'apps/generator/test/test-templates/react-template/__transpiled/test-file.md.js' In the __transpiled folder there are autogenerated files. |
|
Hey @ItshMoh, I've moved the file implementation to the correct folder. Let me know if this looks good or if any adjustments are needed. |
| const TestFile = ({ asyncapi, params }) => { | ||
| return ( | ||
| <File name="test-file.md"> | ||
| <Text>This is a markdown file for my application.</Text> | ||
| <Text>App name is: **{ asyncapi.info().title() }**</Text> | ||
| <Text>Version {params.version} running on {params.mode} mode </Text> | ||
| </File> | ||
| ); | ||
| } No newline at end of file | ||
| } |
There was a problem hiding this comment.
How's about using function syntax as it was used before in place of arrow functions since this will maintain the code consistency of the codebase.
There was a problem hiding this comment.
Implemented the feature using the 'function' keyword
|
|
sorry but it doesn't make sense to make this change to a template that is just there for development looks like we forgot to update sonar when we created monorepo I will close this PR and if you really wanna help, please open a new PR and update https://github.com/asyncapi/generator/blob/master/.sonarcloud.properties with proper link to test dir in apps/generator, you can add test dir for nunjucks templates as well |
Hey @derberg, I've updated the paths to the test directories as requested in PR #1311. Is this the update you were looking for? |
Description