-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ERR_PACKAGE_PATH_NOT_EXPORTED
when react 18 is installed in project
#242
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
/ptal |
@jonaslagoni @magicmatatjahu Please take a look at this PR. Thanks! 👋 |
/rtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like Windows does not like your paths.. I had the same problem in some of my libraries, my solution was to simplify what part of the path was tested 🙂
I have now run the tests locally on both linux and windows, and they are passing. I don't like the fix I did for them, but didn't know how else to solve it. Without the |
Quality Gate passedIssues Measures |
@all-contributors please add @Julusian for bugs, test, code |
I've put up a pull request to add @Julusian! 🎉 |
🎉 This PR is included in version 1.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
If react 18 is installed into the project, the generator can get confused and use 18 when transpiling.
This is a problem as the file
./cjs/react-jsx-runtime.production.min
is not exported by react anymore, resulting in the generation failing:This fixes the issue, by passing the bundler the absolute path to the react file to use, resulting in it always using the react 17 that is a dependency of this library
Related issue(s)