-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding support to change the collection type for arrays in Java models #1437
Conversation
…orrull/asyncapi-cli into feat/collectionTypeJavaSupport
Added the new javaArrayType property from the command generate models into the documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
/u |
/u |
Quality Gate passedIssues Measures |
@borrull could you sync with @jonaslagoni as you might conflict with #1376 |
@borrull, do you want me to add your code to https://github.com/asyncapi/modelina/tree/next/modelina-cli or do you want to help make the contribution there? |
@jonaslagoni if it can wait for 2-3 hours, I can make the contribution there. Otherwise, please go ahead :-) |
All yours @borrull, need your help if you are up for it✌️ |
Description
This PR adds support to change the collection type in Java models by introducing a new parameter "javaArrayType" to the generate models command.
Related issue(s)
Resolves #1436