Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : Add description tooltips to tags pills #1090

Closed
wants to merge 3 commits into from

Conversation

Manancode
Copy link
Contributor

I've created a reusable TooltipWrapper component in library/src/components/TooltipWrapper.tsx
However, I've been unable to locate the exact component or file where the External Docs information is currently rendered. As a result, I can't yet implement the full solution. It would be helpful if someone helps me with the location of external docs information . Till then I am submitting this draft PR which includes a TooltipWrapper component.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Oct 15, 2024

We require all PRs to follow Conventional Commits specification.
More details 👇🏼

 No release type found in pull request title "feat : Add description tooltips to tags pills". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@Manancode Manancode changed the title Add description tooltips to tags pills (#1084) feat : Add description tooltips to tags pills (#1084) Oct 15, 2024
@Manancode Manancode changed the title feat : Add description tooltips to tags pills (#1084) feat : Add description tooltips to tags pills Oct 15, 2024
@catosaurusrex2003
Copy link
Contributor

Hey @Manancode

i would suggest

instead of adding any new dependencies for tootips

we can use the native tool-tips title of html
just like how it has been done in tags
here in https://github.com/asyncapi/asyncapi-react/blob/master/library/src/components/Href.tsx#L18

also
rename your pr from feat : {your text} to feat: {your text} . we follow https://www.conventionalcommits.org/en/v1.0.0/ and hence your Pr linting is failing.

Copy link

sonarcloud bot commented Oct 16, 2024

@Manancode Manancode closed this by deleting the head repository Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants