Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spline interpolation between different unit physical types #1190

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

rosteen
Copy link
Contributor

@rosteen rosteen commented Nov 4, 2024

Fixes #1186. Part of this accidentally snuck into a commit on main while I was doing the last release 😬 (changing from index 0 to using min and max) but this completes the fix. @StuartLittlefair would you confirm that you get what you expected in #1186 with this fix?

@rosteen rosteen added bug manipulation Spectral manipulation tools labels Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.95%. Comparing base (c4b90ed) to head (f275690).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1190   +/-   ##
=======================================
  Coverage   86.95%   86.95%           
=======================================
  Files          63       63           
  Lines        4568     4568           
=======================================
  Hits         3972     3972           
  Misses        596      596           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StuartLittlefair
Copy link
Contributor

Thanks @rosteen - this is perfect

@rosteen rosteen merged commit 4bcf381 into astropy:main Nov 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug manipulation Spectral manipulation tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spline interpolation no longer works for binning on velocity grid
2 participants