-
-
Notifications
You must be signed in to change notification settings - Fork 58
Implement CircleSectorPixelRegion #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@larrybradley is this a desired feature? Are there any guidelines with respect to adding new shapes to regions? |
|
@adonath This looks like a nice addition to me! Implementing the "exact" mode for exact partial pixel overlaps could be tricky. |
|
I'd love to help with this. What do we need to get it across the finish line? |
|
@adonath are you still working on this? If the example works, maybe we can just merge (after resolving conflicts) and leave the unimplemented modes as open issues? |
|
@jzuhone @keflavich I have not made any progress since, but I would be happy rebase and open issues for the remaining tasks. |
This PR is a draft to implement a
CircleSectorPixelRegion. I needed this for a specific analysis, so I decided to just implement it. Here is a notebook to illustrate that the bounding box and contains methods work correctly for all quadrants https://github.com/adonath/notebooks-public/blob/master/circle_sector_pix_region_illustration.ipynbSome ToDos:
CircleSectorSkyRegionCircleSectorPixelRegion.to_sky()CircleSectorPixelRegion.to_mask()