Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip Lorentz2D until it can be supported #244

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

braingram
Copy link
Contributor

@braingram braingram commented Sep 28, 2024

astropy added astropy.modeling.functional_models.Lorentz2D see #243

This PR adds the unsupported model to the list of unsupported models to fix the devdeps.

This PR does not close the associated issue as we'll need to:

  • make a schema
  • add the schema to asdf-transform-schemas
  • add a converter to this package

so let's leave the issue open to track that work.

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.44%. Comparing base (51ede39) to head (c2aced3).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...tropy/converters/transform/tests/test_transform.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #244   +/-   ##
=======================================
  Coverage   99.44%   99.44%           
=======================================
  Files          54       54           
  Lines        1992     1994    +2     
=======================================
+ Hits         1981     1983    +2     
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram marked this pull request as ready for review September 28, 2024 17:02
@braingram braingram merged commit 826578a into astropy:main Nov 4, 2024
27 of 29 checks passed
@braingram braingram deleted the skip_lorentz2d branch November 4, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant