Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Circle CI to run Integration Test #1769

Merged
merged 6 commits into from
Dec 23, 2024
Merged

Configure Circle CI to run Integration Test #1769

merged 6 commits into from
Dec 23, 2024

Conversation

pritt20
Copy link
Contributor

@pritt20 pritt20 commented Dec 19, 2024

Description

Configure/Setup existing circle CI pipeline to include newly added integration tests as part of PR validations.

This new IT's CI run will require an approval to trigger the pipeline, so that we do not trigger these ITs on every push and can be triggered once changes are ready and conserve some resources.

🎟 Issue(s)

Related #1754

🧪 Functional Testing

Tested the new integration test CI Pipeline in this PR and all test were invoked as expected. Please find the link below for reference:

https://app.circleci.com/pipelines/github/astronomer/astro-cli/6063/workflows/0ba0dc71-0501-408d-b97a-e961e3d2e9ef/jobs/12594

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@pritt20 pritt20 marked this pull request as ready for review December 20, 2024 17:30
@pritt20 pritt20 requested a review from schnie December 20, 2024 17:35
Copy link
Contributor

@neel-astro neel-astro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have ITs :) pre-approving with minor nits.

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@neel-astro neel-astro merged commit 7b75a8e into main Dec 23, 2024
5 checks passed
@neel-astro neel-astro deleted the update_ci branch December 23, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants