Skip to content

Commit

Permalink
make it so you can create a kuberenetes deployment with a file create…
Browse files Browse the repository at this point in the history
…d from --template (#1413)

* fix file

* fix test
  • Loading branch information
sunkickr authored and neel-astro committed Oct 12, 2023
1 parent 4022475 commit ca3184e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 14 deletions.
3 changes: 3 additions & 0 deletions cloud/deployment/inspect/inspect.go
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,9 @@ func getTemplate(formattedDeployment *FormattedDeployment) FormattedDeployment {
}
}
template.Deployment.EnvVars = newEnvVars
if template.Deployment.Configuration.Executor == deployment.KubeExecutor {
template.Deployment.WorkerQs = nil
}

return template
}
15 changes: 1 addition & 14 deletions cloud/deployment/inspect/inspect_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1161,20 +1161,7 @@ func TestFormatPrintableDeployment(t *testing.T) {
"cloud_provider": "",
"region": ""
},
"worker_queues": [
{
"name": "default",
"worker_type": "test-instance-type",
"pod_cpu": "smallCPU",
"pod_ram": "megsOfRam"
},
{
"name": "test-queue-1",
"worker_type": "test-instance-type-1",
"pod_cpu": "LotsOfCPU",
"pod_ram": "gigsOfRam"
}
],
"worker_queues": null,
"alert_emails": [
"email1",
"email2"
Expand Down

0 comments on commit ca3184e

Please sign in to comment.