add support for imagepullsecrets in pgbouncer certgen service (#423)

astronomer · Apr 25, 2023 · 78bb7b0 · 78bb7b0
1 parent 1fe06ec
commit 78bb7b0
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/templates/generate-ssl.yaml b/templates/generate-ssl.yaml
@@ -67,6 +67,10 @@ spec:
         component: pgbouncer
         release: {{ .Release.Name }}
     spec:
+      {{- if or .Values.airflow.registry.secretName .Values.airflow.registry.connection }}
+      imagePullSecrets:
+        - name: {{ template "astro.registry_secret" . }}
+      {{- end }}
       restartPolicy: Never
       serviceAccountName: {{ .Release.Name }}-pgbouncer-ssl
       containers:

diff --git a/tests/chart_tests/test_pgbouncer_certgenerator.py b/tests/chart_tests/test_pgbouncer_certgenerator.py
@@ -35,3 +35,20 @@ def test_pgbouncer_certgenerator_with_sslmode_enabled(self, kube_version):
         assert "Role" == jmespath.search("kind", docs[1])
         assert expected_rbac in docs[1]["rules"]
         assert "RoleBinding" == jmespath.search("kind", docs[2])
+
+    def test_pgbouncer_certgenerator_with_custom_registry_secret(self, kube_version):
+        """Test pgbouncer certgenerator sslmode opts result."""
+        docs = render_chart(
+            kube_version=kube_version,
+            values={
+                "airflow": {
+                    "registry": {"secretName": "gscsecret"},
+                    "pgbouncer": {"enabled": True, "sslmode": "require"},
+                }
+            },
+            show_only="templates/generate-ssl.yaml",
+        )
+        assert len(docs) == 4
+        assert [{"name": "gscsecret"}] == docs[3]["spec"]["template"]["spec"][
+            "imagePullSecrets"
+        ]