Skip to content

Commit

Permalink
update sidecar triggerer args (#441)
Browse files Browse the repository at this point in the history
* update sidecar triggerer args

* updated test cases
  • Loading branch information
pgvishnuram authored Jul 24, 2023
1 parent 5e77aaf commit 51f6d25
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 0 deletions.
17 changes: 17 additions & 0 deletions tests/chart_tests/test_triggerer.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
from tests.chart_tests.helm_template_generator import render_chart


class TestTriggerer:
def test_triggerer_log_grommer_defaults(self):
"""Test Triggerer Log Groomer defaults."""
docs = render_chart(
values={
"airflow": {"airflowVersion": "2.4.3"},
},
show_only=["charts/airflow/templates/triggerer/triggerer-deployment.yaml"],
)
assert len(docs) == 1
assert (
"/usr/local/bin/clean-airflow-logs"
in docs[0]["spec"]["template"]["spec"]["containers"][1]["args"]
)
6 changes: 6 additions & 0 deletions values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,12 @@ airflow:
logGroomerSidecar:
args: ["/usr/local/bin/clean-airflow-logs"]

triggerer:
persistence:
enabled: false
logGroomerSidecar:
args: ["/usr/local/bin/clean-airflow-logs"]

# Airflow webserver settings
webserver:
allowPodLogReading: false
Expand Down

0 comments on commit 51f6d25

Please sign in to comment.