Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependabot for cargo dependencies #7034

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Add dependabot for cargo dependencies #7034

merged 1 commit into from
Sep 1, 2023

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Aug 31, 2023

Ideally we shouldn't have to run cargo update manually — it requires us to remember to do so and groups all updates into a single pull request making it challenging to determine which upgrade introduces regressions e.g. #6964. Here we add daily checks for cargo dependency updates.

This pull request also simplifies dependabot configuration for GitHub Actions versions.

Also, simplifies GH Actions dependabot configuration
@zanieb zanieb added the internal An internal refactor or improvement label Aug 31, 2023
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can give it a try. Rolling back is easy. I always found dependabot a pain when working on JS projects.

@charliermarsh
Copy link
Member

I'm open to trying it.

One request: when we merge Dependabot PRs, can we standardize on manually removing the PR body, to avoid these excessively long Git logs?

Screen Shot 2023-09-01 at 2 56 42 PM

@zanieb
Copy link
Member Author

zanieb commented Sep 1, 2023

@charliermarsh should we change the default squash commit message (in general) to just be pull request titles?

@zanieb zanieb merged commit 253a241 into main Sep 1, 2023
16 checks passed
@zanieb zanieb deleted the dependabot branch September 1, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants