[red-knot] Improve ergonomics for the PySlice
trait
#13983
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Just a minor change to improve the ergonomics of the
PySlice
trait. By implementingPySlice
for[T]
rather than&[T]
, we can call it onVec<T>
andBox<[T]>
without having to have intermediate calls to.as_slice()
or.as_ref()
. It can still be called on&[T]
and&Box<[T]>
, because thepy_slice
trait method takes&self
.Test Plan
cargo test -p red_knot_python_semantic