[red-knot] Remove Type::Unbound
#13980
Draft
+578
−389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkdp
force-pushed
the
david/remove-type-unknown
branch
from
9d7b8dd
to
8e97da6
Compare
sharkdp
commented
Oct 30, 2024
| @@ -120,7 +120,7 @@ if returns_bool(): | |||
| __name__ = 1 | |||
|
|
|||
| reveal_type(__file__) # revealed: Literal[42] | |||
| reveal_type(__name__) # revealed: str | Literal[1] | |||
| reveal_type(__name__) # revealed: Literal[1] | str | |||
There was a problem hiding this comment.
To do: restore original order?
sharkdp
commented
Oct 30, 2024
Comment on lines
71
to
72
| # error: [non-subscriptable] "Cannot subscript object of type `Literal[Spam, Spam]` with no `__class_getitem__` method" | ||
| # revealed: Unknown |
sharkdp
commented
Oct 30, 2024
Comment on lines
988
to
999
| let any_unbound = union | ||
| .elements(db) | ||
| .iter() | ||
| .any(|ty| ty.member(db, name).is_unbound()); | ||
| if any_unbound { | ||
| SymbolLookupResult::Unbound // TODO | ||
| } else { | ||
| SymbolLookupResult::Bound( | ||
| union.map(db, |ty| ty.member(db, name).expect_bound()), | ||
| Boundedness::DefinitelyBound, | ||
| ) | ||
| } |
sharkdp
force-pushed
the
david/remove-type-unknown
branch
from
edb4d6e
to
0175a1b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Early draft, no need to review
Summary
Remove
Type::Unbound.closes #13671
TODO
todo_unwrap_type()Do we need the concept of declaredness in addition to boundness?not necessarily for the first version of thisSymbolLookupResult(see ideas in ticket)CallOutcometo handle unboundness, such that we can usety.class_member(…).call(…), with a newSymbolLookupResult::callmethod? Or maybety.class_member(…).call_result_ty(…)?UnboundTest Plan
TODO