Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use the system allocator for codspeed benchmarks" #13035

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

MichaReiser
Copy link
Member

Reverts #13005

I don't see any improvements. I think it's even worse then before.

@MichaReiser MichaReiser added the ci Related to internal CI tooling label Aug 21, 2024
Copy link

codspeed-hq bot commented Aug 21, 2024

CodSpeed Performance Report

Merging #13035 will degrade performances by 9.74%

Comparing revert-13005-use-system-allocator-for-codspeed (f7103b7) with main (ecd9e6a)

Summary

⚡ 9 improvements
❌ 1 (👁 1) regressions
✅ 22 untouched benchmarks

Benchmarks breakdown

Benchmark main revert-13005-use-system-allocator-for-codspeed Change
linter/default-rules[large/dataset.py] 3.9 ms 3.7 ms +5.62%
👁 linter/default-rules[numpy/globals.py] 170.5 µs 189 µs -9.74%
linter/default-rules[pydantic/types.py] 1.9 ms 1.8 ms +5.57%
linter/all-with-preview-rules[pydantic/types.py] 10.2 ms 9.7 ms +5.16%
linter/all-with-preview-rules[unicode/pypinyin.py] 2.5 ms 2.4 ms +4.48%
parser[large/dataset.py] 5.6 ms 4.9 ms +12.86%
parser[numpy/ctypeslib.py] 998.5 µs 910.7 µs +9.64%
parser[numpy/globals.py] 112.7 µs 101.6 µs +10.95%
parser[pydantic/types.py] 2.1 ms 2 ms +6.73%
parser[unicode/pypinyin.py] 350.6 µs 308.9 µs +13.5%

Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser MichaReiser merged commit f873d2a into main Aug 21, 2024
20 checks passed
@MichaReiser MichaReiser deleted the revert-13005-use-system-allocator-for-codspeed branch August 21, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to internal CI tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants