Skip to content

Commit

Permalink
[red-knot] Narrowing - Not operator (#13942)
Browse files Browse the repository at this point in the history
## Summary

After #13918 has landed, narrowing constraint negation became easy, so
adding support for `not` operator.

## Test Plan

Added a new mdtest file for `not` expression.

---------

Co-authored-by: Carl Meyer <[email protected]>
  • Loading branch information
TomerBin and carljm authored Oct 28, 2024
1 parent 1f19aca commit 74cf66e
Show file tree
Hide file tree
Showing 2 changed files with 51 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
# Narrowing for `not` conditionals

The `not` operator negates a constraint.

## `not is None`

```py
def bool_instance() -> bool:
return True

x = None if bool_instance() else 1

if not x is None:
reveal_type(x) # revealed: Literal[1]
else:
reveal_type(x) # revealed: None

reveal_type(x) # revealed: None | Literal[1]
```

## `not isinstance`

```py
def bool_instance() -> bool:
return True

x = 1 if bool_instance() else "a"

if not isinstance(x, (int)):
reveal_type(x) # revealed: Literal["a"]
else:
reveal_type(x) # revealed: Literal[1]
```
19 changes: 18 additions & 1 deletion crates/red_knot_python_semantic/src/types/narrow.rs
Original file line number Diff line number Diff line change
Expand Up @@ -129,13 +129,30 @@ impl<'db> NarrowingConstraintsBuilder<'db> {
}

fn evaluate_expression_constraint(&mut self, expression: Expression<'db>, is_positive: bool) {
match expression.node_ref(self.db).node() {
let expression_node = expression.node_ref(self.db).node();
self.evaluate_expression_node_constraint(expression_node, expression, is_positive);
}

fn evaluate_expression_node_constraint(
&mut self,
expression_node: &ruff_python_ast::Expr,
expression: Expression<'db>,
is_positive: bool,
) {
match expression_node {
ast::Expr::Compare(expr_compare) => {
self.add_expr_compare(expr_compare, expression, is_positive);
}
ast::Expr::Call(expr_call) => {
self.add_expr_call(expr_call, expression, is_positive);
}
ast::Expr::UnaryOp(unary_op) if unary_op.op == ast::UnaryOp::Not => {
self.evaluate_expression_node_constraint(
&unary_op.operand,
expression,
!is_positive,
);
}
_ => {} // TODO other test expression kinds
}
}
Expand Down

0 comments on commit 74cf66e

Please sign in to comment.