feat(AIR302-name): "load_connections" and "get_connection" was rename…

…d in "airflow.secrets.local_filesystem"
astral-sh · Dec 6, 2024 · 499d549 · 499d549
1 parent 7e056c7
commit 499d549
Show file tree

Hide file tree

Showing 3 changed files with 181 additions and 144 deletions.
diff --git a/crates/ruff_linter/resources/test/fixtures/airflow/AIR302_names.py b/crates/ruff_linter/resources/test/fixtures/airflow/AIR302_names.py
@@ -13,6 +13,7 @@
 )
 from airflow.metrics.validators import AllowListValidator
 from airflow.metrics.validators import BlockListValidator
+from airflow.secrets.local_filesystem import get_connection, load_connections
 from airflow.utils import dates
 from airflow.utils.dates import (
     date_range,
@@ -54,6 +55,9 @@
 dates.datetime_to_nano
 
 get, getboolean, getfloat, getint, has_option, remove_option, as_dict, set
+
+get_connection, load_connections
+
 TemporaryDirectory
 mkdirs
 

diff --git a/crates/ruff_linter/src/rules/airflow/rules/removal_in_3.rs b/crates/ruff_linter/src/rules/airflow/rules/removal_in_3.rs
@@ -162,6 +162,19 @@ fn removed_name(checker: &mut Checker, expr: &Expr, ranged: impl Ranged) {
                         "airflow.metrics.validators.PatternBlockListValidator".to_string(),
                     ),
                 )),
+                // airflow.secrets
+                ["airflow", "secrets", "local_filesystem", "load_connections"] => Some((
+                    qualname.to_string(),
+                    Replacement::Name(
+                        "airflow.secrets.local_filesystem.load_connections_dict".to_string(),
+                    ),
+                )),
+                ["airflow", "secrets", "local_filesystem", "get_connection"] => Some((
+                    qualname.to_string(),
+                    Replacement::Name(
+                        "airflow.secrets.local_filesystem.load_connections_dict".to_string(),
+                    ),
+                )),
                 // airflow.utils.dates
                 ["airflow", "utils", "dates", "date_range"] => Some((
                     qualname.to_string(),