Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wikimedia/less.php from 3.0 to 5.x #38

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

Krinkle
Copy link
Contributor

@Krinkle Krinkle commented Jul 2, 2024

https://github.com/wikimedia/less.php/blob/master/CHANGES.md

  • 3.x: Fix bugs, add PHP 8.x support (fix warnings), improve performance.
  • 4.0: Require PHP 7.4+.
  • 4.x: Fix bugs, improve performance, add various missing Less.js features, full compliance with Less.js 2.5.3.
  • 5.0:
    • Remove deprecated methods on Less_Parser, which Assetic doesn't use.
    • Fix breakage of slash in various new CSS features.
    • Change "math" default from "always" to "parens-division", same as upstream Less.js 4.x.

@Krinkle Krinkle requested a review from a team as a code owner July 2, 2024 23:26
@bennothommo
Copy link
Member

Thanks for the PR @Krinkle. I won't change the PHP requirement, as the wikimedia/less.php usage here is just for the tests - people are free to choose whichever version they want for their own project when using Assetic.

@bennothommo bennothommo merged commit a6027f1 into assetic-php:master Jul 3, 2024
7 checks passed
@Krinkle Krinkle deleted the patch-1 branch July 3, 2024 03:26
@Krinkle
Copy link
Contributor Author

Krinkle commented Jul 3, 2024

@bennothommo Okay. Thanks for landing this. I suggested the change because the current versions of wintercms/winter and winter/storm already require PHP 8, so I figured maybe the next release of Assetic could raise the bar slightly as well.

@bennothommo
Copy link
Member

@Krinkle I'm definitely not adverse to us dropping support for PHP 7 in the next major release, but I believe this library is in use outside of Winter, so didn't want to make any presumptions on what PHP versions are being used there. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants