Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made Embeddings work #1

Merged
merged 8 commits into from
Mar 24, 2024
Merged

Made Embeddings work #1

merged 8 commits into from
Mar 24, 2024

Conversation

cpetersen
Copy link
Member

This PR includes a couple of items:

  • Mainly this makes the Candle::Model.new.embedding method work properly, so the following Ruby should generate a valid embedding:
require 'candle'
model = Candle::Model.new
embedding = model.embedding("Hi there!")
  • Refactors ModelConfig into RbModel to better match the rest of the classes. It's possible this would be better as RbBertModel, I'm not clear on that yet.
  • Implements Enumerable in the ruby Candle::Tensor model, just for developer ergonomics.
  • Updated the README

@kojix2 kojix2 merged commit cca1da9 into assaydepot:main Mar 24, 2024
1 check passed
@kojix2
Copy link
Collaborator

kojix2 commented Mar 24, 2024

Thanks!

@cpetersen
Copy link
Member Author

Thank you for creating the gem!

@kojix2
Copy link
Collaborator

kojix2 commented Mar 29, 2024

Do you want to release Gem?

@cpetersen
Copy link
Member Author

Sorry I missed this. I was out of office last week. I saw you released it, thank you! 👏

@kojix2
Copy link
Collaborator

kojix2 commented Apr 7, 2024

Thanks for the reply. But I haven't released the gem yet.

I recently gave you the right to commit to this repository and to upload to RubyGem. So you are free to release a new Gem if you wish to do so.

I am thinking of transferring the project to red-data-tools as it would be difficult for me to continue it. Also, cpetersen, if your team wants to continue developing the project, I can transfer the entire project from here to assaydepot.

@cpetersen
Copy link
Member Author

Hi! Thank you for clarifying, I just pushed version 0.0.4.

Thank you for developing red-candle, if you aren't in a position to continue, we (assaydepot) would be happy to maintain it. If you'd rather transfer it to red-data-tools, I completely understand. If we need further functionality we will continue to submit PRs.

@kojix2
Copy link
Collaborator

kojix2 commented Apr 9, 2024

@cpetersen

Thank you for releasing this new Gem. I would be very happy to have you take over the development of red-candle. I would like to transfer this repository to assaydepot if you don't mind.

Currently, I am unable to transfer this repository to assaydepot because it already has red-candle. Could you please temporarily rename or remove the fork repository?

Thank you for again your valuable contribution.

Best regards

image

@cpetersen
Copy link
Member Author

Great, thank you! I just deleted our fork, so we should be all set. Thank you again for creating this project!

@kojix2
Copy link
Collaborator

kojix2 commented Apr 10, 2024

Thank you for your cooperation.

I found out that the repository can only be transferred by authorized persons in the organization.

To transfer a repository that you own to an organization, you must have permission to create a repository in the target organization.

https://docs.github.com/repositories/creating-and-managing-repositories/transferring-a-repository

So, I have transferred red-candle to your personal account (cpetersen). I would appreciate it if you could check your e-mail and approve it.

@cpetersen
Copy link
Member Author

Makes sense, I just accepted and will transfer on to assaydepot once it completes.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants