Set FormatEnumsAsIntegers to true by default #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enums should be formatted as integers by default, as deserializing string-based enums can cause exceptions when the value names (not the values themselves) are changed, or when new values are added (unlike integers, which are handled gracefully on deserialization generally).
|
I realize this might have ramifications for consumers of this package, but I think it makes sense to make this change, just not sure when. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enums should be formatted as integers by default, as deserializing string-based enums can cause exceptions when the value names (not the values themselves) are changed, or when new values are added (unlike integers, which are handled gracefully on deserialization generally).